Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade dune file. #903

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

build: Upgrade dune file. #903

wants to merge 4 commits into from

Conversation

Et7f3
Copy link
Member

@Et7f3 Et7f3 commented Jun 7, 2020

With my current approach It worked but I have used a soudness issue. It was patched in upstream compiler: So it didn't work anymore.
Dune in 2.4 added a feature that might be the proper workaround: ocaml/dune#3141. And we need 2.4. I have used dune upgrade and we get a large diff: So I have splited in two PR. (Anyways dune dev suggest to use dune 2 format so it is still a chore to do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant